Issue Details (XML | Word | Printable)

Key: SPRG-3
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Trivial Trivial
Assignee: dinesh
Reporter: Greg (Gregity)
Votes: 2
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Auc-Util-ScanProgress

ScanProgress doesn't finish scan properly, sometimes remains at 1+ seconds left

Created: 03/Aug/08 09:36 PM   Updated: 06/Nov/09 09:29 AM
Component/s: GUI
Affects Version/s: 4.0.5
Fix Version/s: None

Environment: Not a problem
Issue Links:
Reference
 


 Description  « Hide
[edit: moving the second enhancement request to a separate JIRA, SPRG-8]

RockSlice asked me to post a link to my forum item here:

http://forums.norganna.org/discussion/7641/changes-to-aucutilscanprogressscanprogresslua-for-consideration/

The text of the items is:
Hi, This may be presumptious of me, but I have a small change I would like to see in ScanProgress.lua. OK, maybe two.

The first is I like to see the % complete when scanning, and the second is that it bugs me to see 1 Sec. left when the scan is done.

So, I made a couple of changes to see if I could get them to work. To wit:

[edit: first fix moved to SPRG-8]

And starting at line 144:
local auctionsScannedPerSecond = scannedAuctions / secondsElapsed
local secondsToScanCompletion = SecondsToTime(auctionsToScan / auctionsScannedPerSecond)
if (currentPage+1 == totalPages) then
secondsToScanCompletion = "Done"
end

BrowseNoResultsText:SetText(
private.scanProgressFormat:format(
"Scanning auctions.",
currentPage + 1,
totalPages,
((currentPage+1)/totalPages)*100,
auctionsScannedPerSecond,
scannedAuctions,
secondsToScanCompletion,
SecondsToTime(secondsElapsed)
)
)

Thanks for all of your great work on this fantastic addon. I use it constantly and am learning to write my own Addons. Your code makes a great learning tool also!!

-Gregity



 All   Comments   Change History   Transitions   FishEye   Crucible      Sort Order: Ascending order - Click to sort in descending order
Speeddymon added a comment - 25/Dec/08 05:12 AM
I agree with the one second thing. As for percentage complete, you pretty much have that, with the scanning page x of x line.. If you really must have it, keep it local and just checkout from the public SVN.

dinesh added a comment - 23/Aug/09 01:22 PM
separating this into two JIRAs.

dinesh added a comment - 23/Aug/09 01:23 PM
matched user requests and patches.

Matthew Benner (MattBnr) added a comment - 06/Nov/09 09:29 AM
marking fixed. feel free to reopen if needed.