Issue Details (XML | Word | Printable)

Key: SIMP-19
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Bryan (brykrys)
Reporter: Bryan (brykrys)
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Auc-Stat-Simple

Collection of minor code improvements

Created: 31/Mar/09 03:56 AM   Updated: 14/Aug/09 01:58 AM
Component/s: Other
Affects Version/s: None
Fix Version/s: None


 Description  « Hide
Issue to collect together minor coding improvements

 All   Comments   Change History   Transitions   FishEye   Crucible      Sort Order: Ascending order - Click to sort in descending order
Bryan (brykrys) added a comment - 31/Mar/09 03:58 AM - edited
In GetPriceData, if an invalid serverKey is passed, should generate a true error instead of a print-to-chat.

Side effect: GetPriceData will now always either: return a valid data table, or not return at all in the case of an error. Can remove check for return value in all calling functions.


Bryan (brykrys) added a comment - 13/Apr/09 08:16 AM
Will also do some work on the data-checking functions at load time.

Bryan (brykrys) added a comment - 13/Apr/09 09:49 AM
r4152
Commited alongside SIMP-20

dinesh added a comment - 14/Aug/09 01:58 AM
code review only