[#INF-68] Change Informant to query GetItemInfo for sell-to-vendor price of an item, rather than pull from our database.

Informant

Change Informant to query GetItemInfo for sell-to-vendor price of an item, rather than pull from our database.

Created: 07/Aug/09 09:22 PM Updated: 16/Dec/09 10:21 PM

Component/s:

Data

Affects Version/s:

5.6.0, 5.7.0

Fix Version/s:

5.6.0, 5.7.0

Description

« Hide

Now that Blizz provides the amount a vendor will pay for an item, we can shrink the database by eliminating that piece from our database and just querying Blizzard. We still need Informant to provide that data for other addons that depend on it, but we don't need to store it ourselves.

All

Comments

Change History

Transitions

FishEye

Crucible

Sort Order:

[ Permalink | « Hide ]

Bryan (brykrys) added a comment - 08/Aug/09 01:37 AM

Most current AddOns use GetSellValue, which Informant provides
http://www.wowwiki.com/GetSellValue

The implementation I'm currently using looks like this:

local gsv = GetSellValue or function() end
GetSellValue = function(item)
	local _,_,_,_,_,_,_,_,_,_,value = GetItemInfo(item)
	return value or gsv(item)
end

[ Permalink | « Hide ]

Hirsute added a comment - 08/Aug/09 02:12 AM

Aye, though I'm fairly certain that Auctioneer doesn't get the sell-to-vendor value from Informant using that function, as when our local data table has been incorrect in the past, Auctioneer has based its decision on the wrong value.

[ Permalink | « Hide ]

Bryan (brykrys) added a comment - 12/Aug/09 06:14 AM

Informant provides an implementation of GetSellValue, which calls lib.GetItem. I would suggest changing this to use GetItemInfo (cutting out the middleman), in addition to the changes to lib.GetItem and the database.

Most other parts of Auctioneer use GetSellValue - including our implementation of GetDepositCost. I think only Informant's tooltip handler uses lib.GetItem directly.