History | Log In     View a printable version of the current page.  
Please note that Jira will be offline Saturday July 26, 2008 from 3:00 AM to 6:00 AM EDT (GMT -4) for scheduled maintenance.
Issue Details (XML | Word | Printable)

Key: GATH-58
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Esamynn
Reporter: Esamynn
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Gatherer

Upgrade swag to use spell ids to retrieve localized spell names.

Created: 13/May/08 07:51 PM   Updated: 09/Jul/08 07:26 PM
Component/s: Acquire
Affects Version/s: 3.1.0, 3.0.6, 3.1.1
Fix Version/s: 3.1.2


 Description  « Hide
We can use know spell ids to retrieve the localized name of all of the gathering spells that we care about.

 All   Comments   Change History   FishEye      Sort Order:
Esamynn - 13/May/08 07:52 PM
Changing the table def of lootSpells to:

-- Spell names and types
do
local GetSpellInfo = function( ... ) return GetSpellInfo(...) or "" end -- prevent nil key errors
myLib.lootSpells = {
[GetSpellInfo(2366)] = "HERB", -- Herb Gathering(Apprentice)
[GetSpellInfo(2575)] = "MINE", -- Mining(Apprentice)
[GetSpellInfo(7620)] = "FISH", -- Fishing(Apprentice)
[GetSpellInfo(8613)] = "SKIN", -- Skinning(Apprentice)
[GetSpellInfo(1804)] = "OPEN", -- Pick Lock()
[GetSpellInfo(3365)] = "OPEN", -- Opening()
[GetSpellInfo(3366)] = "OPEN", -- Opening()
[GetSpellInfo(6247)] = "OPEN", -- Opening()
[GetSpellInfo(6249)] = "OPEN", -- Opening()
[GetSpellInfo(6477)] = "OPEN", -- Opening()
[GetSpellInfo(6478)] = "OPEN", -- Opening()
[GetSpellInfo(6509)] = "OPEN", -- Opening()
[GetSpellInfo(6658)] = "OPEN", -- Opening()
[GetSpellInfo(6802)] = "OPEN", -- Opening()
[GetSpellInfo(8917)] = "OPEN", -- Opening()
[GetSpellInfo(21248)] = "OPEN", -- Opening()
[GetSpellInfo(21288)] = "OPEN", -- Opening()
[GetSpellInfo(21651)] = "OPEN", -- Opening()
[GetSpellInfo(24390)] = "OPEN", -- Opening()
[GetSpellInfo(24391)] = "OPEN", -- Opening()
[GetSpellInfo(26868)] = "OPEN", -- Opening()
[GetSpellInfo(39220)] = "OPEN", -- Opening()
[GetSpellInfo(39264)] = "OPEN", -- Opening()
[GetSpellInfo(45137)] = "OPEN", -- Opening()
[GetSpellInfo(22810)] = "OPEN", -- Opening - No Text()
}
myLib.lootSpells[""] = nil -- clear out any useless entries
end

should do the trick.

Nikk (Nechckn) - 09/Jul/08 07:26 PM
Verified in dev/Trunk- SpellIDs now used to avoid any localization issues.