[#GATH-28] Ensure extra fading cannot ever actually increase mini note opacity

Gatherer

Toggle general node visibility based upon last inspection time (GATH-15)

Ensure extra fading cannot ever actually increase mini note opacity

Created: 16/Jan/08 01:11 PM Updated: 18/Feb/08 04:12 PM

Component/s:

GUI

Affects Version/s:

3.0.2, 3.0.3, 3.0.0, 3.0.1, 3.0.4

Fix Version/s:

3.0.5

Description

« Hide

In GatherMiniNotes.lua lines 228-264, we need to ensure that the extra fading that can be done because of node distance and/or inspection can never cause the overall opacity to actually be increased.

All

Comments

Change History

FishEye

Sort Order:

[ Permlink | « Hide ]

Kinesia - 18/Jan/08 12:52 AM

<Kinesia> Esamynn|Away the current code will run into issues if the fadePerc is higher than the default opacity, because they are both absolute values. So if your default is 50% and your fade is 80% you'll end up at -30% where you probably want it to be 10% (faded down 80% of the 50...)
<Kinesia> Are they in percent format already? I'd probably say it should be "local fadeLevel = (opacity * fadePerc) * ratio" then a fadePerc of 0 will leave you with your default opacity in the next line and a fadePerc of 100% will leave you with an Opacity of 0.

[ Permlink | « Hide ]

Esamynn - 18/Jan/08 01:29 PM

The changes to the icon opacity system will need to be released noted as there will probably be some users will need to adjust their settings because of this change.

[ Permlink | « Hide ]

Kinesia - 19/Jan/08 06:29 AM

This looks correct to me.

[ Permlink | « Hide ]

Kinesia - 24/Jan/08 07:14 PM

New code seems to work correctly.

[ Permlink | « Hide ]

Esamynn - 18/Feb/08 04:11 PM

Reopening issue to change its fix version.

[ Permlink | « Hide ]

Esamynn - 18/Feb/08 04:12 PM

This is fixed in whatever the next Gatherer release is.