History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: GATH-19
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Esamynn
Reporter: Thomas Spear (Speeddymon)
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Gatherer

GatherMiniNotes.lua line 217: attempt to compare nil with number

Created: 25/Oct/07 10:02 AM   Updated: 16/Jan/08 12:11 AM
Component/s: Mapping
Affects Version/s: 3.0.2, 3.0.3, 3.0.0, 3.0.1
Fix Version/s: 3.0.4


 Description  « Hide
Date: 2007-10-25 08:12:13
ID: 51
Error occured in: Global
Count: 336
Message: ..\AddOns\Gatherer\GatherMiniNotes.lua line 217:
   attempt to compare nil with number
Debug:
   [C]: ?
   Gatherer\GatherMiniNotes.lua:217: UpdateMinimapNotes()
   [string "*:OnUpdate"]:1:
      [string "*:OnUpdate"]:1
[-snip-]


It seems like the embeds are messed up somehow, however I am not able to figure out how to test if they are. There haven't been any changes to this file since august, aside from moving it to a subfolder inside of trunk, but I only just started getting the error. It also seems to occur every time I change subzones, because the notes disappear from the minimap for several seconds each time I do, and then reappear as if it is correcting itself.

 All   Comments   Change History   FishEye      Sort Order:
Thomas Spear (Speeddymon) - 28/Oct/07 04:10 PM - edited
After talking with RockSlice for a bit about this issue, it is related to an update of the addon Town Guard. The old version of Town Guard used an old version of Astrolabe, which somehow (at least it seems) was only tracking and affecting the Town Guard minimap icons, so that when :RemoveAllMinimapIcons() was called, only the Town Guard icons were being removed. When I updated Town Guard, WoW started using the Gatherer copy of Astrolabe because the 2 versions were the same, and so :RemoveAllMinimapIcons() now removes _all_ minimap icons, including the gatherer ones, which causes the aforementioned error. Changing line 203 of GatherMiniNotes.lua to show the following at least fixes the error:

local nodeDist = Astrolabe:GetDistanceToIcon(gatherNote) or 0

However the gatherer minimap icons still disappear as well, which is not optimal.

I will work with the Town Guard dev to find a more appropriate solution than removing all of the icons.

Thomas Spear (Speeddymon) - 01/Nov/07 09:29 PM
It also seems a more appropriate solution would be to have Astrolabe track each addon it is creating icons for, and only remove that addon's icons..

Esamynn - 16/Nov/07 06:55 PM
I will update Gatherer in order to prevent the Lua error for popping up (short term fix).

For the longer term a new version of Astrolabe will be released that will support per-addon tracking of managed Minimap nodes.