[#BCNT-269] If column order is changed, the default sort will not save

BeanCounter

If column order is changed, the default sort will not save

Created: 09/Aug/09 08:15 PM Updated: 13/Aug/09 08:46 AM

Component/s:

Config, GUI

Affects Version/s:

None

Fix Version/s:

None

Description

« Hide

Tested by deleting the columnorder section of settings, sorted by date, and reloaded, and upon opening up BC the sort order was properly remembered on the Date column. Then reordered the Date column to be second last (with UIReason last), and reloaded, and the sort order wasn't saved, it was sorted by ItemName. Then sorted by Date again, reloaded again, and the sort order was still not saved and was sorted by Itemname again.

All

Comments

Change History

Transitions

FishEye

Crucible

Sort Order:

[ Permalink | « Hide ]

William (Kandoko) added a comment - 11/Aug/09 04:02 PM - edited

ok looks like this is caused by the saved value always being overwritten by the value passed in via the configator processor when table is being created.

in detail,
1) We create our scrollframe
2) We pass in the stored re-arrangement information for the rearranged scrollsheet
3) This triggers a kit:Render() and kit:PerformSort()
4) The Processor sends the kit:PerformSort() event and BeanCounter dutifly overwrites the old column sort value with the one passed.
5) We now lookup our saved column sort (which has just been overwritten >.<) and apply

[ Permalink | « Hide ]

William (Kandoko) added a comment - 11/Aug/09 04:32 PM

r4393
If user has rearranged the beancounter column order, the users last selected column to sort by and sort direction, will be properly applied next across play sessions.

Simple fix, just don't register(create the event processor) function until all saved settings have been applied to the scrollsheet.

[ Permalink | « Hide ]

dinesh added a comment - 13/Aug/09 08:46 AM

Tested