Issue Details (XML | Word | Printable)

Key: ADV-435
Type: New Feature New Feature
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Bryan (brykrys)
Reporter: Bryan (brykrys)
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Auctioneer

Add a specialized "Auction Length Selector" function to be used with Selectbox controls

Created: 05/Dec/08 09:20 AM   Updated: 17/Aug/09 11:29 PM
Component/s: Utils
Affects Version/s: 5.5.0
Fix Version/s: None


 Description  « Hide
This relates to the common use of a selectbox for selecting auction duration (12/24/48 hours), generally to use with GetDepositCost()

Each one uses an identical local table for the select options, for example in Auc-Util-AutoMagic.lua:

local ahdeplength = {
{12, "12 hour"},
{24, "24 hour"},
{48, "48 hour"},
}

Suggestion: create a new control, e.g. "AuctionLengthSelect", which would be a Selectbox hardcoded to use a single instance of this table.
Revised: Add a utility function which returns such a table, for use in standard SelectBox controls.

It would mean only one place for this table to be localized (and maintained, if Blizzard changes Auction durations again), but it's a bit hard to tell if the space saving would offset the extra function code that would be needed.



 All   Comments   Change History   Transitions   FishEye   Crucible      Sort Order: Ascending order - Click to sort in descending order
Esamynn added a comment - 11/Dec/08 07:12 PM
This isn't a bad idea, but I don't believe it belongs in Configator. Perhaps such a template could live in the auctioneer core?

Bryan (brykrys) added a comment - 12/Dec/08 03:23 AM
I had some thoughts about this, and was coming to much the same conclusion. We don't need a whole new control, just a static table and a lib function to return it,

local auclentable = {
{12, "12 hour"},
{24, "24 hour"},
{48, "48 hour"},
}
function lib.AucLengthSelector ()
return auclentable
end

Where lib is wherever this ends up. As you say, it is really only relevant to Auctioneer.


Matthew Del Buono (Shirik) added a comment - 12/Jan/09 01:00 AM
Closing issue as it seems to be of consensus that this does not belong in Configator

Bryan (brykrys) added a comment - 05/May/09 02:37 PM
Moved to Auctioneer core and reopened
Change to title and description
Belongs in CoreUtil.lua

Bryan (brykrys) added a comment - 05/May/09 02:45 PM - edited
Proposal: use the pre-exisiting translations strings for "12 hour" etc., from Appraiser (e.g. "APPR_Interface_12Hours") as they have already been translated (I see no reason to make new localizer strings and make people translate them again, if they will be identical...)

Bryan (brykrys) added a comment - 06/May/09 10:07 AM
r4200

dinesh added a comment - 17/Aug/09 11:29 PM
code review only